perf(GraphQL): Part-4: Child auth queries are derived from auth filtered parents (GRAPHQL-854) #7111
Conversation
abhimanyusinghgaur
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
|
✔️ Deploy preview for dgraph-docs ready! 🔨 Explore the source changes: 4a00b50 🔍 Inspect the deploy logs: https://app.netlify.com/sites/dgraph-docs/deploys/5fd25bc7d62da400083f1e28 😎 Browse the preview: https://deploy-preview-7111--dgraph-docs.netlify.app |
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @abhimanyusinghgaur and @MichaelJCompton)
graphql/resolve/query_rewriter.go, line 969 at r1 (raw file):
// This query aggregates all filters and auth rules and is used by root query to filter // the final nodes for the current level. // User6 as var(func: uid(User2), orderasc: ...) @filter((eq(User.username, "User1") AND (...Auth Filter))))
check if orderasc is applied here
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @MichaelJCompton and @pawanrawal)
graphql/resolve/query_rewriter.go, line 969 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
check if orderasc is applied here
Done.
This PR optimizes auth query rewriting by deriving child auth queries from auth filtered parents instead of all possible parents. This reduces the number of
touched_uidsat deep levels. This performance benefit comes into effect when there are a lot of nested levels in auth rules.This change is